Skip to content

Use size_t to store heaps count #19482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use size_t to store heaps count #19482

wants to merge 2 commits into from

Conversation

alexandre-daubois
Copy link
Member

After #19447 (comment)

I chose size_t over other alternatives because spl_heap_elem() already uses size_t for its index param, and heap's max size also uses this type.

@alexandre-daubois alexandre-daubois marked this pull request as ready for review August 14, 2025 14:19
TimWolla
TimWolla reviewed Aug 14, 2025
View reviewed changes
Girgias
Girgias reviewed Aug 14, 2025
View reviewed changes
Girgias
Girgias approved these changes Aug 14, 2025
View reviewed changes
TimWolla
TimWolla requested changes Aug 14, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

@TimWolla TimWolla TimWolla approved these changes

Assignees
No one assigned
Labels
Extension: spl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandre-daubois @TimWolla @Girgias